Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: fix linter warnings reported by golangci-lint #522

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

simonklee
Copy link
Contributor

Fix linter warning reported by golangci-lint.

Fixes #519

@simonklee simonklee force-pushed the fix-linter-warnings branch from 67ccbc4 to d003ee3 Compare November 6, 2023 21:12
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #522 (d003ee3) into master (c47ddfc) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #522   +/-   ##
=======================================
  Coverage   97.58%   97.59%           
=======================================
  Files          19       19           
  Lines         871      872    +1     
=======================================
+ Hits          850      851    +1     
  Misses         15       15           
  Partials        6        6           
Files Coverage Δ
completion.go 100.00% <ø> (ø)
fine_tunes.go 100.00% <100.00%> (ø)

@vvatanabe
Copy link
Collaborator

@sashabaranov Is there any reason why dot imports have been used until now? If there are no particularly critical issues, I think it would be okay to remove the non-recommended dot imports in this PR.

@sashabaranov
Copy link
Owner

@simonklee wow, I've underestimated the amount of changes needed to fix these issues. Thank you so much, you are the best! 🏅

@vvatanabe I think it was used just for convenience, and it didn't cause any linter errors so far (seems like we've got a linter update 😅)

@sashabaranov sashabaranov merged commit 0664105 into sashabaranov:master Nov 7, 2023
3 checks passed
@simonklee simonklee deleted the fix-linter-warnings branch November 7, 2023 09:23
@simonklee
Copy link
Contributor Author

@simonklee wow, I've underestimated the amount of changes needed to fix these issues. Thank you so much, you are the best! 🏅

No worries :)

@vvatanabe
Copy link
Collaborator

@simonklee This PR will make it easier to work on many other PRs! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the latest linter errors
3 participants